✨ Extended string normalization #283
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mk-mxp
approved these changes
Dec 2, 2024
Contributor
mk-mxp
left a comment
mk-mxp
left a comment
There was a problem hiding this comment.
I don't see any blocking changes...
vaeng
approved these changes
Dec 2, 2024
Correctly normalize mixed string and interpolation.
Use `{$c}` over `${c}` after PHP 8.2 deprecation.
homersimpsons
force-pushed
the
feature/extended-string-normalization
branch
from
ed11126 to
d1ec68b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Correctly normalize mixed string and interpolation.
Use
{$c}over${c}after PHP 8.2 deprecation.@mk-mxp Maybe you want to take a look into this one.
Technically, this changes the normalization. But I expect the number of affected solutions to be rather low and not worth a full re-computation.